Skip to content

feat: batch sell wire up quote fetching#30284

Draft
infiniteflower wants to merge 9 commits into
swaps-4439-batchSell-quotes-3from
swaps-4439-batchSell-quotes-4
Draft

feat: batch sell wire up quote fetching#30284
infiniteflower wants to merge 9 commits into
swaps-4439-batchSell-quotes-3from
swaps-4439-batchSell-quotes-4

Conversation

@infiniteflower
Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-swaps-and-bridge Swaps and Bridge team label May 15, 2026
@github-actions github-actions Bot added size-XL and removed size-L labels May 16, 2026
@infiniteflower infiniteflower changed the title feat: (batchSell-quotes-4 first commit) setup useBatchSellQuoteRequest feat: batch sell wire up quote fetching May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSwap, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changes are contained within the Bridge/Swap Batch Sell feature area. The PR wires up real quote fetching for the Batch Sell flow, replacing placeholder data with actual BridgeController integration. Key changes include:

  1. Redux slice (CRITICAL): Added batchSellSourceTokenAmounts state, new actions, and selectBatchSellQuotes selector wrapping the base controller selector.
  2. Bridge selectors: Added selectBatchSellSourceWalletAddress for wallet address resolution in batch sell.
  3. BatchSellReview: Major refactor integrating real quote data via useBatchSellQuoteRequest and useBatchSellQuoteData hooks, replacing all placeholder values.
  4. BatchSellPercentageSlider: Changed minimum snap point from 0% to 25% - behavioral change.
  5. BatchSellTokenSelect: Now initializes source token amounts, destination token, and slippages before navigating to review.
  6. New hooks: useBatchSellQuoteRequest and useBatchSellQuoteData implement the actual quote fetching and formatting logic.

The changes are scoped to the Bridge/Swap Batch Sell feature. SmokeSwap covers bridge and swap functionality including the bridge action tests. Per SmokeSwap tag description, SmokeConfirmations must also be selected since transaction confirmations are part of the swap/bridge flow. No other test areas (accounts, network, identity, snaps, etc.) are affected by these changes.

Performance Test Selection:
The changes are focused on the Batch Sell feature within Bridge/Swap - adding quote fetching logic, new Redux state fields, and UI wiring. While there is some new data processing (quote formatting, BigNumber calculations), these are not in performance-critical paths like app startup, account list rendering, or login flows. The changes don't affect any of the performance test areas (account list, onboarding, login, swaps performance, app launch, asset loading, predict, or perps). No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 0
Missing keys 15
Type mismatches 0
Value mismatches 12 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant